Add standalone activity to throughput stress (opt-in)#351
Open
prathyushpv wants to merge 8 commits into
Open
Conversation
Adds a DoStandaloneActivity ClientAction that invokes the payload activity directly via the low-level StartActivityExecution / PollActivityExecution RPCs, bypassing normal workflow activity scheduling. Mirrors the standalone activity pattern in bench-go's throughputstress scenario. Gated behind --option enable-standalone-activity=true since the API requires server-side support for workflow-independent activities. Only implemented in the Go SDK; other SDKs raise a non-retryable ApplicationFailure if the variant is encountered.
Replace the flat bytes_to_receive/bytes_to_return shape with an embedded ExecuteActivityAction so the standalone-RPC path receives the same activity input contract as the workflow-scheduled path. The executor honors activity_type, task_queue, all four timeouts, and retry_policy from the embedded action; workflow-only fields (awaitable_choice, locality, priority, fairness_*) are ignored. Helper StandaloneActivityClientAction is replaced by a StandaloneActivity factory mirroring DefaultRemoteActivity, so the same ExecuteActivityAction builders target either path.
This reverts commit 49bf421.
DoStandaloneActivity now embeds an ExecuteActivityAction instead of duplicating payload-activity fields, so the standalone-RPC path and the workflow-scheduled path receive the same activity input contract and share dispatch via ActivityNameAndArgs. The executor honors activity_type, task_queue, all four timeouts, and retry_policy from the embedded action; workflow-only fields (awaitable_choice, locality, priority, fairness_*) are ignored. Scenario invocation switches to payload(256, 256) with a 100ms / x1 RetryPolicy to match bench-go's standalone-activity prebuilt request shape. Result is decoded for the payload activity to catch encoding drift between the two scheduling layers.
Migrate executeStandaloneActivity from the raw StartActivityExecution / PollActivityExecution gRPC stubs to client.ExecuteActivity + handle.Get, which is available in Go SDK v1.43.0. This drops manual payload encoding, result decoding, failure parsing, and the Namespace plumbing through ClientActionsExecutor; namespace is picked up from the SDK client. Move ConvertFromPBRetryPolicy to loadgen/kitchensink so both the workflow path (launchActivity) and the standalone path can share it. Extract createStandaloneActivity into a tpsExecutor method to match the pattern used by other throughput_stress action constructors.
…ivity Drop the fallback to e.WorkflowOptions.TaskQueue in ClientActionsExecutor.executeStandaloneActivity and the conditional 30s StartToCloseTimeout default in the StandaloneActivity helper — callers must now set both on the activity directly. Inline the (now-trivial) StandaloneActivity helper into throughput_stress.createStandaloneActivity to match how createSelfDescribe, createSelfQuery, etc. construct their ClientAction protos.
THardy98
requested changes
Jun 2, 2026
Contributor
THardy98
left a comment
THardy98
left a comment
There was a problem hiding this comment.
Generally - would prefer if we kept parity between languages for the operations they support in kitchensink, especially since the code snippet to implement is quite small:
func (e *ClientActionsExecutor) executeStandaloneActivity(ctx context.Context, sa *DoStandaloneActivity) error {
act := sa.GetActivity()
if act == nil {
return fmt.Errorf("DoStandaloneActivity.activity is required")
}
actType, args := ActivityNameAndArgs(act)
handle, err := e.Client.ExecuteActivity(ctx, client.StartActivityOptions{
ID: fmt.Sprintf("standalone-%s-%d", e.WorkflowOptions.ID, time.Now().UnixNano()),
TaskQueue: act.TaskQueue,
ScheduleToCloseTimeout: act.ScheduleToCloseTimeout.AsDuration(),
ScheduleToStartTimeout: act.ScheduleToStartTimeout.AsDuration(),
StartToCloseTimeout: act.StartToCloseTimeout.AsDuration(),
HeartbeatTimeout: act.HeartbeatTimeout.AsDuration(),
RetryPolicy: ConvertFromPBRetryPolicy(act.RetryPolicy),
}, actType, args...)
if err != nil {
return fmt.Errorf("failed to start standalone activity: %w", err)
}
return handle.Get(ctx, nil)
}
across the languages.
If it's pressing to get this in asap, filing an issue would be great so we can track where parity is missing
| "do_standalone_activity is not implemented for .NET", | ||
| "UnsupportedOperation", | ||
| nonRetryable: true); | ||
| } |
Contributor
There was a problem hiding this comment.
There's a flag that exists called err-if-unimplemented or something like that. This is probably a place where we want to check if that's set. If it's false, then we should probably just log instead of throw.
(applies to the other langs where we haven't implemented this as well)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
DoStandaloneActivityClientAction to the kitchen-sink DSL that invokes thepayloadactivity directly via the low-levelStartActivityExecution/PollActivityExecutionRPCs, bypassing normal workflow activity scheduling.throughput_stressbehind a new--option enable-standalone-activity=trueflag (default off).NamespacethroughClientActionsExecutor(required for the namespace-scoped RPCs).ApplicationFailureif the variant is encountered.Why?
Mirrors the standalone activity pattern in bench-go's
throughputstressscenario so we can benchmark workflow-independent activities (StartActivityExecution/PollActivityExecution) in omes.